New inflow #911
Open
New inflow #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AboudyKreidieh
requested review from
cathywu,
eugenevinitsky and
kanaadp
as code owners
Pull Request Test Coverage Report for Build 5763
💛 - Coveralls |
kanaadp
requested changes
Apr 25, 2020
| accel += np.random.normal(0, self.accel_noise) | ||
| if self.ignore_noise is None: | ||
| # Add noise to the vehicle for all positions in this case. | ||
| accel += np.random.normal(0, self.accel_noise) |
There was a problem hiding this comment.
realized that this should probably be seeded with SUMO seed as well.
| edge=self._inflows[name]["edge"], | ||
| pos=0, | ||
| lane=self._inflows[name]["departLane"], | ||
| speed=depart_speed |
There was a problem hiding this comment.
how does this work if adding a vehicle at the beginning of the lane with the given depart_speed is unsafe? Does it have the same behavior as SUMO inflows (either wait, adapt, or throw away the existing vehicle)?
| @@ -13,6 +13,8 @@ | |||
| from bisect import bisect_left | |||
| import itertools | |||
| from copy import deepcopy | |||
| import random | |||
There was a problem hiding this comment.
same as above, we should sync the seeds to get reproducibility
kanaadp
reviewed
Apr 25, 2020
| name = names[i + 1] | ||
|
|
||
| # Choose the departure speed. | ||
| depart_speed = self._inflows[name]["departSpeed"] |
There was a problem hiding this comment.
should this also be adaptive?
kanaadp
requested changes
Apr 25, 2020
| else 0) | ||
| ) | ||
|
|
||
| for veh_num in range(num_vehicles): |
There was a problem hiding this comment.
at each time step, we should shuffle the vehicles to be added so they're not added in batches (i.e. 5 humans, then 2 avs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request information
Description
ignore_noiseoption to the controllers to deactivate noise near the start of networksVehicleParamsclass. This gives us more control on how vehicles enter the network.ignore_noisefeature.